From 1cb67b8c6bfe58ed8be4123207b2eb8871928dc7 Mon Sep 17 00:00:00 2001
From: Raimon Tolosana-Delgado <tolosa53@fwg206.ad.fz-rossendorf.de>
Date: Tue, 29 Jun 2021 11:56:26 +0200
Subject: [PATCH] bugs in accuracy, precision and goodness corrected
---
R/accuracy.R | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/R/accuracy.R b/R/accuracy.R
index 6efeb95..887c1e8 100644
--- a/R/accuracy.R
+++ b/R/accuracy.R
@@ -210,7 +210,8 @@ accuracy.DataFrameStack <- function(x, observed,
#' @family accuracy functions
mean.accuracy = function(x, ...){
aux = x$accuracy - x$p
- mean(ifelse(aux>0,1,0),...)
+ n = nrow(x)
+ n/(n-1)*mean(ifelse(aux>0,1,0),...)
}
@@ -250,8 +251,9 @@ precision <- function(x,...) UseMethod("precision",x)
#' @export
precision.accuracy <- function(x, ...){
aux = x$accuracy - x$p
- erg = c(precision=1-2* x$accuracy %*% ifelse(aux>0,aux,0),
- goodness = 1-(3*x$accuracy-2) %*% aux)/nrow(x)
+ a = ifelse(aux>0,1,0)
+ erg = c(precision=1-2*(a %*% aux)/(nrow(x)-1),
+ goodness = 1-((3*a-2) %*% aux)/(nrow(x)-1))
return(erg)
}
--
GitLab