Configurations: device measured quantities not selectable for dynamic locations
In a configuration with a dynamic location type, the measured quantities of the selected device are not shown. There is just a 'no data available' hint.
Example configuration: http://rz-vm64.gfz-potsdam.de/configurations/8
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- Nils Brinckmann changed the description
changed the description
By Marc Hanisch on 2021-06-16T12:44:13 (imported from GitLab)
- Author Owner
I can't see a bug there - the device has no measured quantities as far as I can see it. A after reloading, I see the measured quantity.
By Nils Brinckmann on 2021-06-16T13:10:57 (imported from GitLab)
Edited by Nils Brinckmann - Author Owner
However, this is also a think that I didn't care in !105 (merged) so far (selection of the devices). (Still the question if we want to care about this & before we add the location actions).
By Nils Brinckmann on 2021-06-16T13:10:18 (imported from GitLab)
- Author Owner
I would like to fix it for the Demo that Jannes is giving on Friday...
By Marc Hanisch on 2021-06-16T13:38:49 (imported from GitLab)
- Author Owner
Makes perfectly sense. Let me know if I can help.
By Nils Brinckmann on 2021-06-16T13:39:33 (imported from GitLab)
- Author Owner
Thanks, @nils! I think the measured quantities (
properties
in the model) are not loaded for the devices in theConfigurationApi.ts
:findById (id: string): Promise<Configuration> { return this.axiosApi.get(id, { params: { include: [ 'contacts', 'configuration_platforms.platform', 'configuration_devices.device', 'src_longitude', 'src_latitude', 'src_elevation' ].join(',') } }).then((rawResponse) => { const rawData = rawResponse.data return configurationWithMetaToConfigurationByThrowingErrorOnMissing(this.serializer.convertJsonApiObjectToModel(rawData)) }) }
Is it possible to even include something like:
configuration_devices.device.properties
(or whatever it is called)?By Marc Hanisch on 2021-06-16T13:50:23 (imported from GitLab)
- Author Owner
Try:
configuration_devices.device.device_properties
- however I still hope that it doesn't fail due as we may have to change the serialization there.By Nils Brinckmann on 2021-06-16T15:53:28 (imported from GitLab)
Collapse replies - Author Owner
Thanks, this worked! I just had to serialize also the device properties for included devices of the configurations. See !114 (merged)
By Marc Hanisch on 2021-06-16T15:57:25 (imported from GitLab)
Edited by Nils Brinckmann
- Nils Brinckmann added Doing label
added Doing label
- Nils Brinckmann created merge request !113 (closed) to address this issue
created merge request !113 (closed) to address this issue
By Marc Hanisch on 2021-06-16T15:52:06 (imported from GitLab)
- Nils Brinckmann mentioned in merge request !113 (closed)
mentioned in merge request !113 (closed)
By Marc Hanisch on 2021-06-16T15:52:06 (imported from GitLab)
- Nils Brinckmann mentioned in merge request !114 (merged)
mentioned in merge request !114 (merged)
By Marc Hanisch on 2021-06-16T15:56:54 (imported from GitLab)
- Nils Brinckmann mentioned in commit 3acf8db3
mentioned in commit 3acf8db3
By Marc Hanisch on 2021-06-17T08:58:52 (imported from GitLab)
- Marc Hanisch mentioned in merge request !132 (merged)
mentioned in merge request !132 (merged)
- Marc Hanisch mentioned in issue #156 (closed)
mentioned in issue #156 (closed)