Issue JOSS review: Installation and packaging improvement suggestions
Hi all, two small suggested improvements based on my attempts to install the package:
- I'm using
uv
to install the package using the commands below (equivalent to creating a virtual env then doingpip install deeptrees
):
uv init
uv add deeptrees
This gave me the following error:
`rasterio` was requested with a pre-release marker (e.g., rasterio==1.4a3), but pre-releases weren't enabled (try: `--prerelease=allow`)`
It's an easy enough workaround on my end to install with --prerelease=allow
, but might be worth updating the rasterio
dependency to a non-pre-release version (e.g. rasterio==1.4.0
) so it's easier to install.
- The
setup.py
says that the package is compatible with any version of Python from 3.10: https://codebase.helmholtz.cloud/taimur.khan/DeepTrees/-/blob/main/setup.py#L20
However, attempting to install in Python 3.13 produced an error due to torch
not being compatible with Python 3.13:
× No solution found when resolving dependencies:
╰─▶ Because torch==2.4.0 has no wheels with a matching Python ABI tag (e.g., `cp313`) and all versions of deeptrees depend on torch==2.4.0, we can conclude that all versions of deeptrees cannot be used.
And because you require deeptrees, we can conclude that your requirements are unsatisfiable.
hint: You require CPython 3.13 (`cp313`), but we only found wheels for `torch` (v2.4.0) with the following Python ABI tags: `cp38`, `cp39`, `cp310`, `cp311`, `cp312`
It might be worth updating setup.py
to REQUIRES_PYTHON = '>=3.10.0,<3.13'
Edited by Robbi Bishop-Taylor