Mobile data sync follow-up
AC
-
parameter name typo: datetimeFrom to dateTimeFrom -
readme: request examples and command for generating schema docker-compose exec -u $UID php-fpm bash -c "bin/console api:graphql:export > schema.graphql"
-
Error Schema must contain unique named types but contains multiple types named "SectionEventBatch"
- duplicate type name -
payload from mobile app contains field id
- it is an internal id and not needed or used in API. However, it is not trivial to remove this parameter on mobile app side and we could add it to the type as non-mandatory field. Potential problem because keywordid
might have special semantics in GraphQL library (done, no problem) -
check if dateTimeTo and dateTimeFrom are valid dates before processing ( InspectionBatchAddMutation
) -
validate if image_refs are null -
(optional) support plain integers as imageRef ids -
Tests are running
Review
-
parameter name typo: datetimeFrom to dateTimeFrom -
readme: request examples and command for generating schema docker-compose exec -u $UID php-fpm bash -c "bin/console api:graphql:export > schema.graphql"
-
Error Schema must contain unique named types but contains multiple types named "SectionEventBatch"
- duplicate type name -
payload from mobile app contains field id
- it is an internal id and not needed or used in API. However, it is not trivial to remove this parameter on mobile app side and we could add it to the type as non-mandatory field. Potential problem because keywordid
might have special semantics in GraphQL library -
check if dateTimeTo and dateTimeFrom are valid dates before processing ( InspectionBatchAddMutation
) -
validate if image_refs are null -
Tests are running
Edited by Michael Voigt