[Security] Bump urllib3 from 1.26.13 to 1.26.17
Bumps urllib3 from 1.26.13 to 1.26.17. This update includes a security fix.
Vulnerabilities fixed
Cookie
HTTP header isn't stripped on cross-origin redirects urllib3 doesn't treat theCookie
HTTP header special or provide any helpers for managing cookies over HTTP, that is the responsibility of the user. However, it is possible for a user to specify aCookie
header and unknowingly leak information via HTTP redirects to a different origin if that user doesn't disable redirects explicitly.Users must handle redirects themselves instead of relying on urllib3's automatic redirects to achieve safe processing of the
Cookie
header, thus we decided to strip the header by default in order to further protect users who aren't using the correct approach.Affected usages
We believe the number of usages affected by this advisory is low. It requires all of the following to be true to be exploited:
- Using an affected version of urllib3 (patched in v1.26.17 and v2.0.6)
- Using the
Cookie
header on requests, which is mostly typical for impersonating a browser.- Not disabling HTTP redirects
- Either not using HTTPS or for the origin server to redirect to a malicious origin.
Remediation
- Upgrading to at least urllib3 v1.26.17 or v2.0.6
- Disabling HTTP redirects using
redirects=False
when sending requests.- Not using the
Cookie
header.Patched versions: 1.26.17 Affected versions: < 1.26.17
Release notes
Sourced from urllib3's releases.
1.26.17
- Added the
Cookie
header to the list of headers to strip from requests when redirecting to a different host. As before, different headers can be set viaRetry.remove_headers_on_redirect
. (GHSA-v845-jxx5-vc9f)1.26.16
- Fixed thread-safety issue where accessing a
PoolManager
with many distinct origins would cause connection pools to be closed while requests are in progress (#2954)1.26.15
- Fix socket timeout value when HTTPConnection is reused (urllib3/urllib3#2645)
- Remove "!" character from the unreserved characters in IPv6 Zone ID parsing (urllib3/urllib3#2899)
- Fix IDNA handling of 'x80' byte (urllib3/urllib3#2901)
1.26.14
- Fixed parsing of port 0 (zero) returning None, instead of 0 (#2850)
- Removed deprecated
HTTPResponse.getheaders()
calls inurllib3.contrib
module.
Changelog
Sourced from urllib3's changelog.
1.26.17 (2023-10-02)
- Added the
Cookie
header to the list of headers to strip from requests when redirecting to a different host. As before, different headers can be set viaRetry.remove_headers_on_redirect
. ([#3139](https://github.com/urllib3/urllib3/issues/3139) <https://github.com/urllib3/urllib3/pull/3139>
_)1.26.16 (2023-05-23)
- Fixed thread-safety issue where accessing a
PoolManager
with many distinct origins would cause connection pools to be closed while requests are in progress ([#2954](https://github.com/urllib3/urllib3/issues/2954) <https://github.com/urllib3/urllib3/pull/2954>
_)1.26.15 (2023-03-10)
- Fix socket timeout value when
HTTPConnection
is reused ([#2645](https://github.com/urllib3/urllib3/issues/2645) <https://github.com/urllib3/urllib3/issues/2645>
__)- Remove "!" character from the unreserved characters in IPv6 Zone ID parsing (
[#2899](https://github.com/urllib3/urllib3/issues/2899) <https://github.com/urllib3/urllib3/issues/2899>
__)- Fix IDNA handling of '\x80' byte (
[#2901](https://github.com/urllib3/urllib3/issues/2901) <https://github.com/urllib3/urllib3/issues/2901>
__)1.26.14 (2023-01-11)
- Fixed parsing of port 0 (zero) returning None, instead of 0. (
[#2850](https://github.com/urllib3/urllib3/issues/2850) <https://github.com/urllib3/urllib3/issues/2850>
__)- Removed deprecated getheaders() calls in contrib module. Fixed the type hint of
PoolKey.key_retries
by addingbool
to the union. ([#2865](https://github.com/urllib3/urllib3/issues/2865) <https://github.com/urllib3/urllib3/issues/2865>
__)
Commits
-
c9016bf
Release 1.26.17 -
0122035
Backport GHSA-v845-jxx5-vc9f (#3139) -
e63989f
Fix installingbrotli
extra on Python 2.7 -
2e7a24d
[1.26] Configure OS for RTD to fix building docs -
57181d6
[1.26] Improve error message when calling urllib3.request() (#3058) -
3c01480
[1.26] Run coverage even with failed jobs -
d94029b
Release 1.26.16 -
18e9214
Use trusted publishing for PyPI -
d25cf83
[1.26] Fix invalid test_ssl_failure_midway_through_conn -
25cca38
[1.26] Fix test_ssl_object_attributes - Additional commits viewable in compare view