Fix bug in paths replacement for search js
For production
pipeline, paths to js and json files are set wrongly: leading //
instead of /
.
Fix that.
Don't forget:
-
revert e8f70aac, i.e. re-add search symbol, once working.
Merge request reports
Activity
assigned to @jandt-desy
added Bug label
- Resolved by Huste, Tobias
@frust45 this seems to fix the bug with the scripts. In
build:production
pipeline, the reference to the main directory is set toSUBPATH: "/"
(so, with a slash at the end), while in review-apps, it's without a slash at the end.This seems to lead to confusion at some points, as at some points, yet another
/
is added, then, leading to non-valid//<filename>
paths.I circumvented simply by changing to
SUBPATH: "/."
inbuild:production
pipeline, so adding another/
doesn't hurt.This seems to work:
- See https://hifis.net/search
- I put the most recent
build:production
artifact from this branch there. - Any other things broken? Doesn't seem so.
- I am not sure if this the most elegant solution, but it seems to work...
Can you please check?
requested review from @frust45
added Progress::4_Can review label
marked the checklist item revert e8f70aac, i.e. re-add search symbol, once working. as completed
removed Progress::4_Can review label
added Progress::6_Can merge label
mentioned in commit 9f2af687
mentioned in merge request !334 (merged)