Skip to content
Snippets Groups Projects

Reformat and reformulate 2x2 buttons

Merged Uwe Jandt (DESY, HIFIS) requested to merge reformat-2x2-buttons into rework-hifisnet-1
All threads resolved!
  • Reformat buttons such that they don't wobble so much between 1/2/3 line formats (by introducing larger max-width and minimum height)
  • Reformulate buttons to same names as in Hamburger menu, where applicable
  • Exchange links for education hamburger menu <> buttons, as of comment in #274
  • Since principally all links of these 2x2 buttons are external, don't add explicit "external" symbol there. Is that appropriate?

:point_right: Review

Edited by Uwe Jandt (DESY, HIFIS)

Merge request reports

Approval is optional

Merged by Uwe Jandt (DESY, HIFIS)Uwe Jandt (DESY, HIFIS) 3 years ago (Apr 1, 2022 8:21am UTC)

Merge details

  • Changes merged into rework-hifisnet-1 with 49482da9.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • @jandt-desy Thanks for taking care. I added a few minor suggestions regarding the location of CSS attributes.

  • Uwe Jandt (DESY, HIFIS) resolved all threads

    resolved all threads

  • Uwe Jandt (DESY, HIFIS) resolved all threads

    resolved all threads

  • added 1 commit

    Compare with previous version

  • added 7 commits

    • 5fffaa9e...33c1d83a - 2 commits from branch rework-hifisnet-1
    • 57ecf416 - minimum height for 2x2 buttons to reduce wobbly behavior
    • 80dfde30 - align button titles with corresponding titles from hamburger menu, if present
    • 4b3bc6ed - align link to courses/education with...
    • 10031bb7 - allow wider buttons to avoid 3-liners in wide screens
    • 232e56ab - move min-height to css

    Compare with previous version

  • mentioned in issue #274 (closed)

  • mentioned in commit 49482da9

  • Please register or sign in to reply
    Loading