Restructure frontend
Goal of this MR:
- restructure the pages and components to reflect user interactions in URLs (eg.
/devices/104/properties/95/edit
) - trigger API methods immediately when adding or removing entities (eg. contacts, properties, custom field forms, attachments)
Merge request reports
Activity
added 1 commit
- e577c81d - reworks contacts page
By Marc Hanisch on 2021-03-08T16:11:42 (imported from GitLab)
added 1 commit
- 93d97121 - triggers input event when contact was added
By Marc Hanisch on 2021-03-08T16:24:25 (imported from GitLab)
added 1 commit
- cee6e04a - only show second action when more than 3 contacts
By Marc Hanisch on 2021-03-08T16:34:18 (imported from GitLab)
added 1 commit
- 3de84bfe - adds some types
By Marc Hanisch on 2021-03-09T08:41:27 (imported from GitLab)
added 2 commits
By Marc Hanisch on 2021-03-09T14:31:21 (imported from GitLab)
added 6 commits
- b3a4eb20 - adds license
- 6b9e31f5 - adds components to show and edit CustomTextFields
- 89c1cebc - adds page for custom fields
- 1a881b44 - adds some methods to serialize not-included CustomFields
- 27be5546 - adds method to load related CustomFields
- f331b4b0 - WIP: adds basic API class for CustomFields
By Marc Hanisch on 2021-03-10T16:15:58 (imported from GitLab)
Toggle commit listadded 7 commits
- b996fbdb - Improved test coverage for custom text field serializer
- 1590fd89 - APi integration for attachments
- 5a346064 - Added device property api
- f0c47704 - Add return values for add & update methods
- ec781942 - Adding & removing contacts for platforms
- f5a95b94 - And the new contact handling for configurations as well
- c0572597 - Merge branch 'feature-restructure-frontend-apis' into feature-restructure-frontend
By Marc Hanisch on 2021-03-11T13:24:16 (imported from GitLab)
Toggle commit listadded 64 commits
-
c0572597...b63223bc - 7 commits from branch
master
- 880cfcbb - adds methods to load and serialize properties of an device
- 08836331 - adds properties main page and loads the properties
- 757f7af4 - Merge branch 'feature-restructure-frontend' into feature-restructure-frontend-properties
- 294e37d2 - adds Expansion panel for device properties
- cda1744c - WIP: adds expansion panels per device property
- beab354b - fixes type annotation
- 9497686b - adds component to display a device's property infos
- 60201e4d - adds focus() method
- a4f574aa - WIP: adds pages for device properties
- 2f57cdd3 - adds default if no label, more space for actions
- 9e744b98 - passes CV entities as component props
- d325f117 - Merge branch 'feature-restructure-frontend' into feature-restructure-frontend-properties
- d937effd - creating, updating and deleting of properties
- de5a2748 - adds / updates licence header
- 61efe058 - prevents default click action, otherwise the view mode is not correct
- 270512f9 - removes unused mounted method
- fc1cafcd - renames loop variable
- 0c877136 - moves loading of entities to fetch method
- 7fb2d4f5 - removes debug output
- b8e9f118 - adds the eager property to the panel content
- 8a06e008 - triggers the focus method on the DevicePropertyForm component
- 37de2313 - WIP: triggers the panel open event explicitly from the edit.vue page
- 998fffe6 - Don't show warnings for the tab values (strings allowed now)
- 6d54913e - Form for measured quantities
- b510fe65 - Complete input form for device properties
- 9ea81fc5 - Use DevicePropertyInfo component
- 556a8a52 - Renamed Id page for measured quantities (former known as properties)
- 95dad781 - Renamed to measured quantities
- 8b945249 - More renaming
- ec86c22e - Dialog for checking if the user wants to delete the device property
- 265fe003 - Removed old property page
- 28422f80 - Another renaming
- 2955be3e - Now use a apply button on a similar position as for custom fields
- 7da1d4a5 - Fix naming (property => measured quantity)
- 686eef8c - Separate Add/save/edit/delete of device attachments
- d3d0074f - Fixed typo for alignment
- df0500ca - Fixed to "remove" wording for deleting device properties
- 2812d878 - Fix wording (remove instead of delete)
- 2d53a0de - Merge branch 'feature-restructure-frontend-properties-nbck' into...
- a1a84d9d - Fix linter issues
- de11048d - Merge branch...
- 31cc287e - Merge branch 'feature-restructure-frontend-properties' into...
- 0121a8f4 - Added confirming dialog for custom fields
- 0574323b - Fixed lint issue
- b694fc23 - Re-added ref to property form
- bb7ab32e - Readded license text
- 034b52b2 - Removed second apply button
- 8e572bea - Removed active css class for cancel button
- 22b3fbbb - Remove active class for cancel buttons
- b04477bb - Merge branch 'feature-restructure-frontend-properties' into...
- 7bb829ba - Renamed "delete xyz..." to "delete"
- 37312432 - Back to readonly properties in edit page for measuredquantities
- 654629e0 - Renamed property in configuration to measured quantity
- 1af3b514 - Merge branch 'feature-restructure-frontend-properties-nbck' into...
- 48ed8edc - Merge branch 'feature-restructure-frontend-nbck-attachments' into...
- 3241f9b3 - Merge branch 'master' into feature-restructure-frontend
- 9b9ec356 - Merge branch 'feature-restructure-frontend-properties' into feature-restructure-frontend
By Marc Hanisch on 2021-03-26T09:18:12 (imported from GitLab)
Toggle commit list-
c0572597...b63223bc - 7 commits from branch
- Resolved by Nils Brinckmann
@nils I've merged the
feature-restructure-frontend-properties
branch into this one (and expected some conflicts), but everything seems to work fine...By Marc Hanisch on 2021-03-26T11:03:44 (imported from GitLab)
Some things that came into my mind regarding the current state of the refactoring:
- As we are done with the devices, we can remove the
pages/olddevices
folder (if it is not even done already) - We need to check for the buttons (those that are active due to the active route).
- Maybe we should move the loading screen animation to the default page as well - currently it darkens the page contents (as it should), but the navbar isn't affected by this.
Maybe also things that @kotyba.alhaj-taha should be aware of.
By Nils Brinckmann on 2021-03-29T08:11:06 (imported from GitLab)
Edited by Nils Brinckmann- As we are done with the devices, we can remove the
- Resolved by Nils Brinckmann
- Resolved by Nils Brinckmann
added 1 commit
- fef19016 - Fix handling of dual use
By Nils Brinckmann on 2021-03-29T15:46:52 (imported from GitLab)
- Resolved by Nils Brinckmann
Another thing: We still have cancel buttons that are greyish (so those that have the
v-btn--active
class), for example on the/devices/_deviceId/basic/edit
page.The main problem on this was the different visual colour (compared with the cancel buttons for the
/devices/_deviceId/measuredquantities/_measuredquantityId/edit
page).I would suggest that we allow the buttons to have the
v-btn--active
class - but that we set their color explicitly.By Nils Brinckmann on 2021-03-30T08:18:12 (imported from GitLab)
- Resolved by Nils Brinckmann
As I currently see it; we have different button colors for adding contacts (blue) and adding for example attachments (green)
By Nils Brinckmann on 2021-04-15T15:54:59 (imported from GitLab)