Skip to content

Feature/localdcm2jsonoperator

Mikulas Bankovic requested to merge feature/localdcm2jsonoperator into develop

#750 (closed) #797 (closed)

  • Added Type Hinting (for clarity)
  • Black formatting
  • Created dcm files for testing:
    • CT, RTSTRUCT and SEG
    • Special symbols / characters, datetime formats, sequence objects, and other dicom tags
    • Compare script for comparing old and new LocalDcm2JsonOperators
  • Removed dcmtk requirement and processing - unnecessary overhead with subprocess call
    • dcm2json - functionality pydicom.Dataset.to_js()
    • dcmmodify - also handled by pydicom
  • Processing time almost the same - new version is faster
  • Renamed variables
    • self.dictionary change to self.dicom_tag_database
    • replace_tags change to normalize___tags
  • Breakdown nested function, branches and exceptions
  • Improved logging - replaced print with logger.info, logger.warning and logger.error
  • Improved datetime, date and time processing - Removed cases that are not according to dicom standard
    • Most obvious was time extraction was done on the null-based values are on the left side, while dicom states they are on the right side:
      • 1120 - does not mean 11 minutes 20 seconds, but 11 hours, 20 minutes.
  • Removed dead code
Edited by Mikulas Bankovic

Merge request reports