Skip to content
Snippets Groups Projects
  1. Jul 18, 2011
    • Simon Tatham's avatar
      Fix version reporting in Unix builds versioned by a specific svn · bd60f2fc
      Simon Tatham authored
      revision ('Custom build r1234'). Those builds were passing
      '-DSVN_REV=r1234' to version.c, instead of -DSVN_REV=1234 as they
      should have, leading to silly run-time version messages such as
      'plink: Custom build rr9226'.
      
      To chop the r off the front of the revision string passed in, I've
      used a bashism in mkunxarc.sh. I think this is an acceptable extra
      dependency.
      
      [originally from svn r9229]
      bd60f2fc
    • Simon Tatham's avatar
      --with-gtk-version option to configure, so you can explicitly tell it · 5cb0fb29
      Simon Tatham authored
      which GTK version you want to build with if both are installed. Based
      on a patch by Malcolm Smith, though somewhat modified.
      
      [originally from svn r9228]
      5cb0fb29
    • Simon Tatham's avatar
      Support for re-running autoconf in the absence of the autoconf macro · 8aea84e8
      Simon Tatham authored
      files which provide auto-detection of GTK 1 and GTK 2. This makes it
      easier for casual PuTTY developers to rerun autoconf for their own
      purposes without having to install obscure extra packages. Obviously
      the resulting configure script will not know how to detect whichever
      version of GTK they didn't have support for, so it won't be product-
      quality by my standards, but it should be good enough that they can
      prepare unrelated patches to send to us.
      
      [originally from svn r9227]
      8aea84e8
  2. Jul 16, 2011
    • Simon Tatham's avatar
      Reorganise the logging and display of messages about SSH · 0b79fe0b
      Simon Tatham authored
      authentication. We should now produce an Event Log entry for every
      authentication attempted and every authentication failure; meanwhile,
      messages in the PuTTY window will not be generated for the failure of
      auth types unless we also announced in the PuTTY window that we were
      trying them. (GSSAPI was getting the latter wrong, leading to spurious
      'Access denied' for many users of 0.61.)
      
      [originally from svn r9226]
      0b79fe0b
    • Simon Tatham's avatar
      Mostly cosmetic change: don't claim to have found an SSH agent if · 8cd720d6
      Simon Tatham authored
      SSH_AUTH_SOCK is defined to the empty string. (Because a common way to
      'unset' it is to run commands like 'SSH_AUTH_SOCK= putty -load thing'.)
      
      [originally from svn r9225]
      8cd720d6
    • Simon Tatham's avatar
      Fix display of VT100 vertically-offset horizontal line characters · 4fd112e1
      Simon Tatham authored
      (o,p,r,s). They are displayed in Windows by actually writing the
      centred one (q) with a vertical offset, in case fonts don't have the
      offset versions; this requires terminal.c to separate those characters
      into distinct calls to do_text(). Unfortunately, it was only breaking
      up a text-drawing call _before_ one of those characters, not after
      one. Spotted by Robert de Bath.
      
      [originally from svn r9221]
      4fd112e1
  3. Jul 15, 2011
  4. Jul 14, 2011
    • Simon Tatham's avatar
      Post-release destabilisation! Completely remove the struct type · a1f3b7a3
      Simon Tatham authored
      'Config' in putty.h, which stores all PuTTY's settings and includes an
      arbitrary length limit on every single one of those settings which is
      stored in string form. In place of it is 'Conf', an opaque data type
      everywhere outside the new file conf.c, which stores a list of (key,
      value) pairs in which every key contains an integer identifying a
      configuration setting, and for some of those integers the key also
      contains extra parts (so that, for instance, CONF_environmt is a
      string-to-string mapping). Everywhere that a Config was previously
      used, a Conf is now; everywhere there was a Config structure copy,
      conf_copy() is called; every lookup, adjustment, load and save
      operation on a Config has been rewritten; and there's a mechanism for
      serialising a Conf into a binary blob and back for use with Duplicate
      Session.
      
      User-visible effects of this change _should_ be minimal, though I
      don't doubt I've introduced one or two bugs here and there which will
      eventually be found. The _intended_ visible effects of this change are
      that all arbitrary limits on configuration strings and lists (e.g.
      limit on number of port forwardings) should now disappear; that list
      boxes in the configuration will now be displayed in a sorted order
      rather than the arbitrary order in which they were added to the list
      (since the underlying data structure is now a sorted tree234 rather
      than an ad-hoc comma-separated string); and one more specific change,
      which is that local and dynamic port forwardings on the same port
      number are now mutually exclusive in the configuration (putting 'D' in
      the key rather than the value was a mistake in the first place).
      
      One other reorganisation as a result of this is that I've moved all
      the dialog.c standard handlers (dlg_stdeditbox_handler and friends)
      out into config.c, because I can't really justify calling them generic
      any more. When they took a pointer to an arbitrary structure type and
      the offset of a field within that structure, they were independent of
      whether that structure was a Config or something completely different,
      but now they really do expect to talk to a Conf, which can _only_ be
      used for PuTTY configuration, so I've renamed them all things like
      conf_editbox_handler and moved them out of the nominally independent
      dialog-box management module into the PuTTY-specific config.c.
      
      [originally from svn r9214]
      a1f3b7a3
  5. Jul 12, 2011
  6. Jul 10, 2011
  7. Jul 01, 2011
    • Jacob Nevins's avatar
      Fix 'winadj-success': since at least one server (boks_sshd) blithely responds · 3a649ed4
      Jacob Nevins authored
      to "winadj@putty.projects.tartarus.org" with SSH_MSG_CHANNEL_SUCCESS despite
      probably having no idea what it means, treat this just the same as
      SSH_MSG_CHANNEL_FAILURE instead of killing the connection.
      Tested only as far as making sure that winadj/FAILURE with a normal server
      isn't _completely_ broken.
      
      [originally from svn r9185]
      [this svn revision also touched putty-wishlist]
      3a649ed4
  8. Jun 25, 2011
    • Simon Tatham's avatar
      Rewrite gprefs() in settings.c so that its input mapping includes · d764872e
      Simon Tatham authored
      information about where to put items that aren't mentioned in the
      saved configuration. So far the only nontrivial use I've made of this
      facility is to default to placing KEX_RSA just above KEX_WARN in the
      absence of any other information, which should fix
      'ssh2-rsa-kex-pref'.
      
      While I'm here I've rewritten wprefs() on general principles to remove
      the needless length limit, since I was touching it anyway. The length
      limit is still in gprefs (but I've lengthened it just in case).
      
      [originally from svn r9181]
      d764872e
  9. Jun 08, 2011
    • Simon Tatham's avatar
      Make Pageant use the same SID-selection logic as the Pageant client · af78191a
      Simon Tatham authored
      code (as introduced in r9043), so that it uses the user SID rather
      than the default SID.
      
      This does change the access-control model, in that a Pageant running
      with administrator privilege will now serve keys to an unprivileged
      PuTTY running as the same user who started Pageant. Owen and I think
      this isn't a problem (in particular, it will still not serve keys to a
      _different_ user).
      
      More importantly, making the Pageant client and server code work the
      same way means that PuTTY and Pageant can still talk to each other
      when UAC is turned off, which we've had several reports of r9043
      having broken.
      
      [originally from svn r9178]
      [r9043 == 05f22632]
      af78191a
    • Simon Tatham's avatar
      When we fail to get a response from Pageant, we should log the fact. · 6e40a0db
      Simon Tatham authored
      Currently, if the IPC exchange goes wrong, the Event Log just prints
      "Pageant is running. Requesting keys." and then goes on to the next
      step without ever saying what happened.
      
      [originally from svn r9177]
      6e40a0db
  10. May 07, 2011
  11. Apr 08, 2011
  12. Mar 09, 2011
  13. Mar 04, 2011
  14. Mar 02, 2011
  15. Feb 22, 2011
  16. Feb 21, 2011
    • Simon Tatham's avatar
      Move the malloc and free of scratch space out of the internal_mul · 77180221
      Simon Tatham authored
      routines into their callers, where they'll be done once for a whole
      modpow rather than many times within each multiply. Doesn't save much
      time as far as I can see - perhaps a couple of percent, one second in
      the minute it takes to run the new bignum test suite - but seems like
      a sensible idea anyway on general principles.
      
      [originally from svn r9103]
      77180221
  17. Feb 20, 2011
Loading