Skip to content
Snippets Groups Projects

Integrate dispatcher

Merged Bert Palm requested to merge integrate_dispatcher into main
All threads resolved!

Merge request reports

Pipeline #490140 passed

Pipeline passed for 9f7d7646 on integrate_dispatcher

Approved by

Merged by Bert PalmBert Palm 2 months ago (Feb 5, 2025 1:00pm UTC)

Merge details

  • Changes merged into main with 3be0eabe.
  • Deleted the source branch.

Pipeline #490201 failed

Pipeline failed for 3be0eabe on main

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Bert Palm added 1 commit

    added 1 commit

    Compare with previous version

  • Bert Palm resolved all threads

    resolved all threads

  • i tried to bring in the dispatcher and the configdb in as it is, more or less a copy with some minor adjustments..

    for content changes (wich might break stuff / needs testing) i suggest to make follo-up MRs..

  • Bert Palm mentioned in merge request !251 (merged)

    mentioned in merge request !251 (merged)

    • Resolved by Joost Hemmen

      Yup, this is a bit of a big one :grimacing:

      I am a bit torn on putting all source code into one directory and copying/mounting that into the cron, configdb and dispatcher images.

      On one hand it is really helpful not having to define libraries like crypto or the journal in several places but to easily share them between images.

      On the other hand i liked having only the dedicated source files and python packages in the respective images/containers. But maybe that is a solution that we can works towards in the next step.

      Edited by Joost Hemmen
  • Joost Hemmen resolved all threads

    resolved all threads

    • Resolved by Joost Hemmen

      tbh I don't exactly know how to review this fully.

      I tested some general workflows, checked critical steps that I could think of. It works flawlessly.

      As this is mostly integrating or moving established cron/dispatcher/configdb-updater code, I assume this is enough.

      Beore deploying on prod we should check the above mentionend images/services a bit more in depth by testing some setup and sync jobs

      Edited by Joost Hemmen
  • Joost Hemmen approved this merge request

    approved this merge request

  • Joost Hemmen resolved all threads

    resolved all threads

  • Joost Hemmen resolved all threads

    resolved all threads

  • merged

  • Bert Palm mentioned in commit 3be0eabe

    mentioned in commit 3be0eabe

  • Please register or sign in to reply
    Loading