Skip to content
Snippets Groups Projects
Commit cb480254 authored by Lars Kollmann's avatar Lars Kollmann
Browse files

#156 add validation for response data to avoid errors

parent 3913c52b
No related branches found
No related tags found
2 merge requests!174Merge develop into master,!150Resolve "Begehung: Refactor Error handling (create/update)"
......@@ -53,6 +53,9 @@ export default class NewsComponent extends Vue {
// todo: put into extra class to avoid duplicated code
private handleData(data: any) {
if (!this.isValidNewsData(data)) {
return;
}
for (const itemEdge of data.data.newsItems.edges) {
for (const contentEdge of itemEdge.node.content.edges) {
const newsContent = {
......@@ -83,4 +86,8 @@ export default class NewsComponent extends Vue {
await NewsService.getInstance().getAllNewsByLanguageWithoutAuth(i18n.locale) :
await NewsService.getInstance().getAllNewsByLanguage( i18n.locale);
}
private isValidNewsData(data: any) {
return data && data.data && data.data.newsItems && data.data.newsItems.edges;
}
}
......@@ -36,7 +36,7 @@ export default class NewsManagement extends Vue {
this.getAllNews(firstCount, language)
.then((data) => {
if (!data.data) {
if (!this.isValidNewsData(data)) {
this.isLoading = false;
return;
}
......@@ -121,4 +121,8 @@ export default class NewsManagement extends Vue {
private delay(millis: number) {
return new Promise((resolve) => setTimeout(resolve, millis));
}
private isValidNewsData(data: any) {
return data && data.data && data.data.newsItems && data.data.newsItems.edges;
}
}
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment