Resolve: feature/802-open-observation-image-galery
closes #802
What was done in this MR?
- The image galery (for the observation image items) was extracted into an
ObservationImageGalery
component that wraps a number ofObservationImageCard
s. (both created, incl. unit tests) - For this some cleanup (mainly polishing the input and output types, as well as removing now unneeded code from
SharedTable
) was necessary - An
OpenImageTable
view was added that manages theObservationImageGalery
for a "Offene Bildtafel" on the route/inspections/galery
. - Slight alignments in
QSStatusIcon
andpagination
which won't interfere with existing code
Caveats:
The OpenImageTable
has some requirements that couldn't be implemented fully yet:
- At the moment there is no way to fetch a list of all Observations (independent from user role and access), ideally filtered by
hasImage
. That has to be added to the BE and must replace afterwards in the FE the.getAllObservations()
inOpenImageTable
. - No proper location obfuscation is currently implemented. The location shown in the map-popup in
ObservationImageCard
is currently a center point of the related Section. (For this matter some kind of fuzziness. Ask Katharina for more info about that.) But a proper location anonymization like in the "flow" project wasn't implemented in the "tmd"-BE either (Alex Grau knows more about that). - For anonymization purposes in the
open
variant of theObservationImageCard
following elements were removed (withopen
prop astrue
):- No Section Name.
- No edit button, that leads to the edit inspection view.
- (Theoretically) obfuscated location on the map.
There is the question if thetransect
-name and thecomment
(which also could contain information that allow conclusions about its author) should be removed. This would likely entail an adjustment of the header of theObservationImageCard
inopen
mode, because there would be too much whitespace.
Before merging this MR - Make sure to create follow up tickets in the front- and backend for following issues:
- Getting a full (!) observation list from the backend
- Getting a properly anonymized location from the backend
Edited by Michael Voigt