Form for measured quantities

This MR refactors the already splitted property page. It addresses issues with opening panels (especially those with an index of 0).

It also uses a more simple approach regarding to nuxt childs. Currently it just handles one possible sub-page for the measured quantities (the edit page).

Hint: Currently the solution with the apply button works, but it feels like a really dirty hack. If we can improve this, I would be really happy with the way it works now.

added 1 commit

• b510fe65 - Complete input form for device properties

Compare with previous version

By Nils Brinckmann on 2021-03-22T12:53:57 (imported from GitLab)

added 1 commit

• 9ea81fc5 - Use DevicePropertyInfo component

Compare with previous version

By Nils Brinckmann on 2021-03-22T14:59:31 (imported from GitLab)

changed the description

By Nils Brinckmann on 2021-03-22T15:00:17 (imported from GitLab)

As it now uses both the DevicePropertyInfo and the DevicePropertyForm components, the overall code looks way simpler.

By Nils Brinckmann on 2021-03-22T15:00:53 (imported from GitLab)

added 2 commits

• 556a8a52 - Renamed Id page for measured quantities (former known as properties)
• 95dad781 - Renamed to measured quantities

Compare with previous version

By Nils Brinckmann on 2021-03-22T15:08:41 (imported from GitLab)

added 3 commits

• 8b945249 - More renaming
• ec86c22e - Dialog for checking if the user wants to delete the device property
• 265fe003 - Removed old property page

Compare with previous version

By Nils Brinckmann on 2021-03-22T15:28:14 (imported from GitLab)

added 1 commit

• 28422f80 - Another renaming

Compare with previous version

By Nils Brinckmann on 2021-03-22T15:30:01 (imported from GitLab)

added 1 commit

• 2955be3e - Now use a apply button on a similar position as for custom fields

Compare with previous version

By Nils Brinckmann on 2021-03-22T16:15:50 (imported from GitLab)

marked this merge request as ready

By Nils Brinckmann on 2021-03-22T16:18:09 (imported from GitLab)

changed the description

By Nils Brinckmann on 2021-03-22T16:18:09 (imported from GitLab)

added 1 commit

• d3d0074f - Fixed typo for alignment

Compare with previous version

By Nils Brinckmann on 2021-03-23T15:35:05 (imported from GitLab)

requested review from @mhanisch

By Nils Brinckmann on 2021-03-24T07:39:08 (imported from GitLab)

added 2 commits

• df0500ca - Fixed to "remove" wording for deleting device properties
• b694fc23 - Re-added ref to property form

Compare with previous version

By Nils Brinckmann on 2021-03-24T14:55:20 (imported from GitLab)

added 1 commit

• bb7ab32e - Readded license text

Compare with previous version

By Nils Brinckmann on 2021-03-24T14:56:37 (imported from GitLab)

added 1 commit

• 034b52b2 - Removed second apply button

Compare with previous version

By Nils Brinckmann on 2021-03-24T14:58:31 (imported from GitLab)

added 1 commit

• 8e572bea - Removed active css class for cancel button

Compare with previous version

By Nils Brinckmann on 2021-03-24T15:35:25 (imported from GitLab)

resolved all threads

By Nils Brinckmann on 2021-03-24T15:42:12 (imported from GitLab)

added 4 commits

• 8e572bea...de11048d - 3 commits from branch feature-restructure-frontend-properties
• b04477bb - Merge branch 'feature-restructure-frontend-properties' into...

Compare with previous version

By Nils Brinckmann on 2021-03-24T15:43:13 (imported from GitLab)

I'm still not that happy with the logic for the saving of the measured quantities - at least with the part of triggering the save method in the measuredquantities.vue file.

Relying on the save method of this child component is a hacky from my point of view.

But I think it is cleaner to work with the copy to edit the fields - and only emitting the value once it is saved. I like how this is done in the child component. But I only don't like how to trigger this from the parent component.

By Nils Brinckmann on 2021-03-25T09:28:43 (imported from GitLab)

Hm, I was also thinking about how to cleanly solve this with Vue, but there are only a few options, beeing refs one of them. Another option would be to pass a property to the child, which reacts to it (saves the measured quantity) and immediately triggers an update to this property - but I doubt that this is more intuitive for the developer... So I'm fine with it.

By Marc Hanisch on 2021-03-25T09:28:43 (imported from GitLab)

approved this merge request

By Marc Hanisch on 2021-03-25T09:28:48 (imported from GitLab)

mentioned in issue #64 (closed)

By Nils Brinckmann on 2021-03-25T10:03:00 (imported from GitLab)

added 1 commit

• 654629e0 - Renamed property in configuration to measured quantity

Compare with previous version

By Nils Brinckmann on 2021-03-25T10:06:29 (imported from GitLab)

mentioned in commit 1af3b514

By Nils Brinckmann on 2021-03-25T12:39:18 (imported from GitLab)