Skip to content
Snippets Groups Projects
  1. May 25, 2018
    • Simon Tatham's avatar
      Build outgoing SSH agent requests in a strbuf. · 0c44fa85
      Simon Tatham authored
      This simplifies the client code both in ssh.c and in the client side
      of Pageant.
      
      I've cheated a tiny bit by preparing agent requests in a strbuf that
      has space reserved at the front for the packet frame, which makes life
      easier for the code that sends them off.
      0c44fa85
  2. Jan 29, 2017
    • Simon Tatham's avatar
      Make asynchronous agent_query() requests cancellable. · eb2fe29f
      Simon Tatham authored
      Now, instead of returning a boolean indicating whether the query has
      completed or is still pending, agent_query() returns NULL to indicate
      that the query _has_ completed, and if it hasn't, it returns a pointer
      to a context structure representing the pending query, so that the
      latter can be used to cancel the query if (for example) you later
      decide you need to free the thing its callback was using as a context.
      
      This should fix a potential race-condition segfault if you overload an
      agent forwarding channel and then close it abruptly. (Which nobody
      will be doing for sensible purposes, of course! But I ran across this
      while stress-testing other aspects of agent forwarding.)
      eb2fe29f
Loading